From 1bac96dc2aa611ba06ff5b8ce8955bd085898508 Mon Sep 17 00:00:00 2001 From: yusing Date: Wed, 2 Oct 2024 01:02:59 +0800 Subject: [PATCH] update docker test --- internal/proxy/provider/docker_test.go | 126 +++++++++++++------------ 1 file changed, 64 insertions(+), 62 deletions(-) diff --git a/internal/proxy/provider/docker_test.go b/internal/proxy/provider/docker_test.go index 45bfae2..52b6c9e 100644 --- a/internal/proxy/provider/docker_test.go +++ b/internal/proxy/provider/docker_test.go @@ -235,73 +235,75 @@ func TestExplicitExclude(t *testing.T) { ExpectFalse(t, ok) } -func TestImplicitExclude(t *testing.T) { - var p DockerProvider - entries, err := p.entriesFromContainerLabels(D.FromDocker(&types.Container{ - Names: dummyNames, - Labels: map[string]string{ - D.LabelAliases: "a", - "proxy.a.no_tls_verify": "true", - }, - State: "running", - }, "")) - ExpectNoError(t, err.Error()) +//! Now nothing will be implicit excluded +// +// func TestImplicitExclude(t *testing.T) { +// var p DockerProvider +// entries, err := p.entriesFromContainerLabels(D.FromDocker(&types.Container{ +// Names: dummyNames, +// Labels: map[string]string{ +// D.LabelAliases: "a", +// "proxy.a.no_tls_verify": "true", +// }, +// State: "running", +// }, "")) +// ExpectNoError(t, err.Error()) - _, ok := entries.Load("a") - ExpectFalse(t, ok) -} +// _, ok := entries.Load("a") +// ExpectFalse(t, ok) +// } -func TestImplicitExcludeNoExposedPort(t *testing.T) { - var p DockerProvider - entries, err := p.entriesFromContainerLabels(D.FromDocker(&types.Container{ - Image: "redis", - Names: []string{"redis"}, - Ports: []types.Port{ - {Type: "tcp", PrivatePort: 6379, PublicPort: 0}, // not exposed - }, - State: "running", - }, "")) - ExpectNoError(t, err.Error()) +// func TestImplicitExcludeNoExposedPort(t *testing.T) { +// var p DockerProvider +// entries, err := p.entriesFromContainerLabels(D.FromDocker(&types.Container{ +// Image: "redis", +// Names: []string{"redis"}, +// Ports: []types.Port{ +// {Type: "tcp", PrivatePort: 6379, PublicPort: 0}, // not exposed +// }, +// State: "running", +// }, "")) +// ExpectNoError(t, err.Error()) - _, ok := entries.Load("redis") - ExpectFalse(t, ok) -} +// _, ok := entries.Load("redis") +// ExpectFalse(t, ok) +// } -func TestNotExcludeSpecifiedPort(t *testing.T) { - var p DockerProvider - entries, err := p.entriesFromContainerLabels(D.FromDocker(&types.Container{ - Image: "redis", - Names: []string{"redis"}, - Ports: []types.Port{ - {Type: "tcp", PrivatePort: 6379, PublicPort: 0}, // not exposed - }, - Labels: map[string]string{ - "proxy.redis.port": "6379:6379", // but specified in label - }, - }, "")) - ExpectNoError(t, err.Error()) +// func TestNotExcludeSpecifiedPort(t *testing.T) { +// var p DockerProvider +// entries, err := p.entriesFromContainerLabels(D.FromDocker(&types.Container{ +// Image: "redis", +// Names: []string{"redis"}, +// Ports: []types.Port{ +// {Type: "tcp", PrivatePort: 6379, PublicPort: 0}, // not exposed +// }, +// Labels: map[string]string{ +// "proxy.redis.port": "6379:6379", // but specified in label +// }, +// }, "")) +// ExpectNoError(t, err.Error()) - _, ok := entries.Load("redis") - ExpectTrue(t, ok) -} +// _, ok := entries.Load("redis") +// ExpectTrue(t, ok) +// } -func TestNotExcludeNonExposedPortHostNetwork(t *testing.T) { - var p DockerProvider - cont := &types.Container{ - Image: "redis", - Names: []string{"redis"}, - Ports: []types.Port{ - {Type: "tcp", PrivatePort: 6379, PublicPort: 0}, // not exposed - }, - Labels: map[string]string{ - "proxy.redis.port": "6379:6379", - }, - } - cont.HostConfig.NetworkMode = "host" +// func TestNotExcludeNonExposedPortHostNetwork(t *testing.T) { +// var p DockerProvider +// cont := &types.Container{ +// Image: "redis", +// Names: []string{"redis"}, +// Ports: []types.Port{ +// {Type: "tcp", PrivatePort: 6379, PublicPort: 0}, // not exposed +// }, +// Labels: map[string]string{ +// "proxy.redis.port": "6379:6379", +// }, +// } +// cont.HostConfig.NetworkMode = "host" - entries, err := p.entriesFromContainerLabels(D.FromDocker(cont, "")) - ExpectNoError(t, err.Error()) +// entries, err := p.entriesFromContainerLabels(D.FromDocker(cont, "")) +// ExpectNoError(t, err.Error()) - _, ok := entries.Load("redis") - ExpectTrue(t, ok) -} +// _, ok := entries.Load("redis") +// ExpectTrue(t, ok) +// }