From 1c892a35f7dc1224e18d3fc3e4b196bc0d6c9111 Mon Sep 17 00:00:00 2001 From: yusing Date: Wed, 9 Apr 2025 16:26:09 +0800 Subject: [PATCH] fix(route): wildcard labels not applied properly --- internal/route/route.go | 7 +------ internal/route/route_test.go | 15 --------------- 2 files changed, 1 insertion(+), 21 deletions(-) diff --git a/internal/route/route.go b/internal/route/route.go index 74e78e5..eba7f4e 100644 --- a/internal/route/route.go +++ b/internal/route/route.go @@ -57,8 +57,7 @@ type ( ProxyURL *net.URL `json:"purl,omitempty"` Idlewatcher *idlewatcher.Config `json:"idlewatcher,omitempty"` - impl route.Route - isValidated bool + impl route.Route } Routes map[string]*Route ) @@ -69,10 +68,6 @@ func (r Routes) Contains(alias string) bool { } func (r *Route) Validate() (err gperr.Error) { - if r.isValidated { - return nil - } - r.isValidated = true r.Finalize() // return error if route is localhost: diff --git a/internal/route/route_test.go b/internal/route/route_test.go index b126db9..29753f4 100644 --- a/internal/route/route_test.go +++ b/internal/route/route_test.go @@ -12,20 +12,6 @@ import ( ) func TestRouteValidate(t *testing.T) { - t.Run("AlreadyValidated", func(t *testing.T) { - r := &Route{ - Alias: "test", - Scheme: route.SchemeHTTP, - Host: "example.com", - Port: route.Port{Proxy: 80}, - Metadata: Metadata{ - isValidated: true, - }, - } - err := r.Validate() - require.NoError(t, err, "Validate should return nil for already validated route") - }) - t.Run("ReservedPort", func(t *testing.T) { r := &Route{ Alias: "test", @@ -146,7 +132,6 @@ func TestRouteValidate(t *testing.T) { } err := r.Validate() require.NoError(t, err) - require.True(t, r.isValidated) require.NotNil(t, r.ProxyURL) require.NotNil(t, r.HealthCheck) })