tweak: replace coder/websocket with gorilla/websocket

This commit is contained in:
yusing 2025-05-19 23:15:11 +08:00
parent cee6eaecff
commit 1f50ee7f2f
16 changed files with 96 additions and 83 deletions

View file

@ -11,7 +11,7 @@ replace github.com/docker/docker => github.com/godoxy-app/docker v0.0.0-20250425
replace github.com/shirou/gopsutil/v4 => github.com/godoxy-app/gopsutil/v4 v4.0.0-20250502022742-408a348f1b97 replace github.com/shirou/gopsutil/v4 => github.com/godoxy-app/gopsutil/v4 v4.0.0-20250502022742-408a348f1b97
require ( require (
github.com/coder/websocket v1.8.13 github.com/gorilla/websocket v1.5.3
github.com/rs/zerolog v1.34.0 github.com/rs/zerolog v1.34.0
github.com/stretchr/testify v1.10.0 github.com/stretchr/testify v1.10.0
github.com/yusing/go-proxy v0.0.0-00010101000000-000000000000 github.com/yusing/go-proxy v0.0.0-00010101000000-000000000000
@ -45,7 +45,6 @@ require (
github.com/gogo/protobuf v1.3.2 // indirect github.com/gogo/protobuf v1.3.2 // indirect
github.com/google/pprof v0.0.0-20250501235452-c0086092b71a // indirect github.com/google/pprof v0.0.0-20250501235452-c0086092b71a // indirect
github.com/gorilla/mux v1.8.1 // indirect github.com/gorilla/mux v1.8.1 // indirect
github.com/gorilla/websocket v1.5.3 // indirect
github.com/gotify/server/v2 v2.6.3 // indirect github.com/gotify/server/v2 v2.6.3 // indirect
github.com/jinzhu/copier v0.4.0 // indirect github.com/jinzhu/copier v0.4.0 // indirect
github.com/leodido/go-urn v1.4.0 // indirect github.com/leodido/go-urn v1.4.0 // indirect

View file

@ -10,8 +10,6 @@ github.com/buger/goterm v1.0.4 h1:Z9YvGmOih81P0FbVtEYTFF6YsSgxSUKEhf/f9bTMXbY=
github.com/buger/goterm v1.0.4/go.mod h1:HiFWV3xnkolgrBV3mY8m0X0Pumt4zg4QhbdOzQtB8tE= github.com/buger/goterm v1.0.4/go.mod h1:HiFWV3xnkolgrBV3mY8m0X0Pumt4zg4QhbdOzQtB8tE=
github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8= github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=
github.com/cenkalti/backoff/v4 v4.3.0/go.mod h1:Y3VNntkOUPxTVeUxJ/G5vcM//AlwfmyYozVcomhLiZE= github.com/cenkalti/backoff/v4 v4.3.0/go.mod h1:Y3VNntkOUPxTVeUxJ/G5vcM//AlwfmyYozVcomhLiZE=
github.com/coder/websocket v1.8.13 h1:f3QZdXy7uGVz+4uCJy2nTZyM0yTBj8yANEHhqlXZ9FE=
github.com/coder/websocket v1.8.13/go.mod h1:LNVeNrXQZfe5qhS9ALED3uA+l5pPqvwXg3CKoDBB2gs=
github.com/containerd/log v0.1.0 h1:TCJt7ioM2cr/tfR8GPbGf9/VRAX8D2B4PjzCpfX540I= github.com/containerd/log v0.1.0 h1:TCJt7ioM2cr/tfR8GPbGf9/VRAX8D2B4PjzCpfX540I=
github.com/containerd/log v0.1.0/go.mod h1:VRRf09a7mHDIRezVKTRCrOq78v577GXq3bSa3EhrzVo= github.com/containerd/log v0.1.0/go.mod h1:VRRf09a7mHDIRezVKTRCrOq78v577GXq3bSa3EhrzVo=
github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc= github.com/coreos/go-systemd/v22 v22.5.0/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=

View file

@ -5,7 +5,7 @@ import (
"io" "io"
"net/http" "net/http"
"github.com/coder/websocket" "github.com/gorilla/websocket"
) )
func (cfg *AgentConfig) Do(ctx context.Context, method, endpoint string, body io.Reader) (*http.Response, error) { func (cfg *AgentConfig) Do(ctx context.Context, method, endpoint string, body io.Reader) (*http.Response, error) {
@ -42,8 +42,12 @@ func (cfg *AgentConfig) Fetch(ctx context.Context, endpoint string) ([]byte, int
} }
func (cfg *AgentConfig) Websocket(ctx context.Context, endpoint string) (*websocket.Conn, *http.Response, error) { func (cfg *AgentConfig) Websocket(ctx context.Context, endpoint string) (*websocket.Conn, *http.Response, error) {
return websocket.Dial(ctx, APIBaseURL+endpoint, &websocket.DialOptions{ transport := cfg.Transport()
HTTPClient: cfg.NewHTTPClient(), dialer := websocket.Dialer{
Host: AgentHost, NetDialContext: transport.DialContext,
NetDialTLSContext: transport.DialTLSContext,
}
return dialer.DialContext(ctx, APIBaseURL+endpoint, http.Header{
"Host": {AgentHost},
}) })
} }

3
go.mod
View file

@ -13,8 +13,8 @@ replace github.com/docker/docker => github.com/godoxy-app/docker v0.0.0-20250425
replace github.com/shirou/gopsutil/v4 => github.com/godoxy-app/gopsutil/v4 v4.0.0-20250502022742-408a348f1b97 replace github.com/shirou/gopsutil/v4 => github.com/godoxy-app/gopsutil/v4 v4.0.0-20250502022742-408a348f1b97
require ( require (
github.com/gorilla/websocket v1.5.3 // websocket for API and agent
github.com/PuerkitoBio/goquery v1.10.3 // parsing HTML for extract fav icon github.com/PuerkitoBio/goquery v1.10.3 // parsing HTML for extract fav icon
github.com/coder/websocket v1.8.13 // websocket for API and agent
github.com/coreos/go-oidc/v3 v3.14.1 // oidc authentication github.com/coreos/go-oidc/v3 v3.14.1 // oidc authentication
github.com/docker/docker v28.1.1+incompatible // docker daemon github.com/docker/docker v28.1.1+incompatible // docker daemon
github.com/fsnotify/fsnotify v1.9.0 // file watcher github.com/fsnotify/fsnotify v1.9.0 // file watcher
@ -121,7 +121,6 @@ require (
github.com/googleapis/gax-go/v2 v2.14.2 // indirect github.com/googleapis/gax-go/v2 v2.14.2 // indirect
github.com/gophercloud/gophercloud v1.14.1 // indirect github.com/gophercloud/gophercloud v1.14.1 // indirect
github.com/gophercloud/utils v0.0.0-20231010081019-80377eca5d56 // indirect github.com/gophercloud/utils v0.0.0-20231010081019-80377eca5d56 // indirect
github.com/gorilla/websocket v1.5.3 // indirect
github.com/hashicorp/go-cleanhttp v0.5.2 // indirect github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
github.com/hashicorp/go-retryablehttp v0.7.7 // indirect github.com/hashicorp/go-retryablehttp v0.7.7 // indirect
github.com/hashicorp/go-uuid v1.0.3 // indirect github.com/hashicorp/go-uuid v1.0.3 // indirect

2
go.sum
View file

@ -768,8 +768,6 @@ github.com/cncf/xds/go v0.0.0-20211011173535-cb28da3451f1/go.mod h1:eXthEFrGJvWH
github.com/cncf/xds/go v0.0.0-20220314180256-7f1daf1720fc/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs= github.com/cncf/xds/go v0.0.0-20220314180256-7f1daf1720fc/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
github.com/cncf/xds/go v0.0.0-20230105202645-06c439db220b/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs= github.com/cncf/xds/go v0.0.0-20230105202645-06c439db220b/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
github.com/cncf/xds/go v0.0.0-20230310173818-32f1caf87195/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs= github.com/cncf/xds/go v0.0.0-20230310173818-32f1caf87195/go.mod h1:eXthEFrGJvWHgFFCl3hGmgk+/aYT6PnTQLykKQRLhEs=
github.com/coder/websocket v1.8.13 h1:f3QZdXy7uGVz+4uCJy2nTZyM0yTBj8yANEHhqlXZ9FE=
github.com/coder/websocket v1.8.13/go.mod h1:LNVeNrXQZfe5qhS9ALED3uA+l5pPqvwXg3CKoDBB2gs=
github.com/containerd/log v0.1.0 h1:TCJt7ioM2cr/tfR8GPbGf9/VRAX8D2B4PjzCpfX540I= github.com/containerd/log v0.1.0 h1:TCJt7ioM2cr/tfR8GPbGf9/VRAX8D2B4PjzCpfX540I=
github.com/containerd/log v0.1.0/go.mod h1:VRRf09a7mHDIRezVKTRCrOq78v577GXq3bSa3EhrzVo= github.com/containerd/log v0.1.0/go.mod h1:VRRf09a7mHDIRezVKTRCrOq78v577GXq3bSa3EhrzVo=
github.com/coreos/bbolt v1.3.2/go.mod h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk= github.com/coreos/bbolt v1.3.2/go.mod h1:iRUV2dpdMOn7Bo10OQBFzIJO9kkE559Wcmn+qkEiiKk=

View file

@ -4,8 +4,7 @@ import (
"net/http" "net/http"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/coder/websocket/wsjson"
config "github.com/yusing/go-proxy/internal/config/types" config "github.com/yusing/go-proxy/internal/config/types"
"github.com/yusing/go-proxy/internal/net/gphttp" "github.com/yusing/go-proxy/internal/net/gphttp"
"github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket" "github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket"
@ -15,8 +14,7 @@ import (
func ListAgents(cfg config.ConfigInstance, w http.ResponseWriter, r *http.Request) { func ListAgents(cfg config.ConfigInstance, w http.ResponseWriter, r *http.Request) {
if httpheaders.IsWebsocket(r.Header) { if httpheaders.IsWebsocket(r.Header) {
gpwebsocket.Periodic(w, r, 10*time.Second, func(conn *websocket.Conn) error { gpwebsocket.Periodic(w, r, 10*time.Second, func(conn *websocket.Conn) error {
wsjson.Write(r.Context(), conn, cfg.ListAgents()) return conn.WriteJSON(cfg.ListAgents())
return nil
}) })
} else { } else {
gphttp.RespondJSON(w, r, cfg.ListAgents()) gphttp.RespondJSON(w, r, cfg.ListAgents())

View file

@ -22,8 +22,7 @@ func RenewCert(w http.ResponseWriter, r *http.Request) {
http.Error(w, err.Error(), http.StatusInternalServerError) http.Error(w, err.Error(), http.StatusInternalServerError)
return return
} }
//nolint:errcheck defer conn.Close()
defer conn.CloseNow()
logs, cancel := memlogger.Events() logs, cancel := memlogger.Events()
defer cancel() defer cancel()
@ -35,7 +34,7 @@ func RenewCert(w http.ResponseWriter, r *http.Request) {
err = autocert.ObtainCert() err = autocert.ObtainCert()
if err != nil { if err != nil {
gperr.LogError("failed to obtain cert", err) gperr.LogError("failed to obtain cert", err)
gpwebsocket.WriteText(r, conn, err.Error()) _ = gpwebsocket.WriteText(conn, err.Error())
} else { } else {
logging.Info().Msg("cert obtained successfully") logging.Info().Msg("cert obtained successfully")
} }
@ -46,7 +45,7 @@ func RenewCert(w http.ResponseWriter, r *http.Request) {
if err != nil { if err != nil {
return return
} }
if !gpwebsocket.WriteText(r, conn, string(l)) { if err := gpwebsocket.WriteText(conn, string(l)); err != nil {
return return
} }
case <-done: case <-done:

View file

@ -1,15 +1,18 @@
package dockerapi package dockerapi
import ( import (
"context"
"errors"
"net/http" "net/http"
"strconv" "strconv"
"github.com/coder/websocket"
"github.com/docker/docker/api/types/container" "github.com/docker/docker/api/types/container"
"github.com/docker/docker/pkg/stdcopy" "github.com/docker/docker/pkg/stdcopy"
"github.com/gorilla/websocket"
"github.com/yusing/go-proxy/internal/logging" "github.com/yusing/go-proxy/internal/logging"
"github.com/yusing/go-proxy/internal/net/gphttp" "github.com/yusing/go-proxy/internal/net/gphttp"
"github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket" "github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket"
"github.com/yusing/go-proxy/internal/task"
) )
func Logs(w http.ResponseWriter, r *http.Request) { func Logs(w http.ResponseWriter, r *http.Request) {
@ -31,6 +34,7 @@ func Logs(w http.ResponseWriter, r *http.Request) {
gphttp.NotFound(w, "server not found") gphttp.NotFound(w, "server not found")
return return
} }
defer dockerClient.Close()
opts := container.LogsOptions{ opts := container.LogsOptions{
ShowStdout: stdout, ShowStdout: stdout,
@ -56,11 +60,14 @@ func Logs(w http.ResponseWriter, r *http.Request) {
if err != nil { if err != nil {
return return
} }
defer conn.CloseNow() defer conn.Close()
writer := gpwebsocket.NewWriter(r.Context(), conn, websocket.MessageText) writer := gpwebsocket.NewWriter(r.Context(), conn, websocket.TextMessage)
_, err = stdcopy.StdCopy(writer, writer, logs) // de-multiplex logs _, err = stdcopy.StdCopy(writer, writer, logs) // de-multiplex logs
if err != nil { if err != nil {
if errors.Is(err, context.Canceled) || errors.Is(err, task.ErrProgramExiting) {
return
}
logging.Err(err). logging.Err(err).
Str("server", server). Str("server", server).
Str("container", containerID). Str("container", containerID).

View file

@ -6,8 +6,7 @@ import (
"net/http" "net/http"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/coder/websocket/wsjson"
config "github.com/yusing/go-proxy/internal/config/types" config "github.com/yusing/go-proxy/internal/config/types"
"github.com/yusing/go-proxy/internal/docker" "github.com/yusing/go-proxy/internal/docker"
"github.com/yusing/go-proxy/internal/gperr" "github.com/yusing/go-proxy/internal/gperr"
@ -65,10 +64,12 @@ func getDockerClient(server string) (*docker.SharedClient, bool, error) {
break break
} }
} }
for _, agent := range cfg.ListAgents() { if host == "" {
if agent.Name() == server { for _, agent := range cfg.ListAgents() {
host = agent.FakeDockerHost() if agent.Name() == server {
break host = agent.FakeDockerHost()
break
}
} }
} }
if host == "" { if host == "" {
@ -115,7 +116,7 @@ func serveHTTP[V any, T ResultType[V]](w http.ResponseWriter, r *http.Request, g
if err != nil { if err != nil {
return err return err
} }
return wsjson.Write(r.Context(), conn, result) return conn.WriteJSON(result)
}) })
} else { } else {
result, err := getResult(r.Context(), dockerClients) result, err := getResult(r.Context(), dockerClients)

View file

@ -4,8 +4,7 @@ import (
"net/http" "net/http"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/coder/websocket/wsjson"
"github.com/yusing/go-proxy/internal/net/gphttp" "github.com/yusing/go-proxy/internal/net/gphttp"
"github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket" "github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket"
"github.com/yusing/go-proxy/internal/net/gphttp/httpheaders" "github.com/yusing/go-proxy/internal/net/gphttp/httpheaders"
@ -15,7 +14,7 @@ import (
func Health(w http.ResponseWriter, r *http.Request) { func Health(w http.ResponseWriter, r *http.Request) {
if httpheaders.IsWebsocket(r.Header) { if httpheaders.IsWebsocket(r.Header) {
gpwebsocket.Periodic(w, r, 1*time.Second, func(conn *websocket.Conn) error { gpwebsocket.Periodic(w, r, 1*time.Second, func(conn *websocket.Conn) error {
return wsjson.Write(r.Context(), conn, routes.HealthMap()) return conn.WriteJSON(routes.HealthMap())
}) })
} else { } else {
gphttp.RespondJSON(w, r, routes.HealthMap()) gphttp.RespondJSON(w, r, routes.HealthMap())

View file

@ -4,8 +4,7 @@ import (
"net/http" "net/http"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/coder/websocket/wsjson"
config "github.com/yusing/go-proxy/internal/config/types" config "github.com/yusing/go-proxy/internal/config/types"
"github.com/yusing/go-proxy/internal/net/gphttp" "github.com/yusing/go-proxy/internal/net/gphttp"
"github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket" "github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket"
@ -15,7 +14,7 @@ import (
func ListRouteProvidersHandler(cfgInstance config.ConfigInstance, w http.ResponseWriter, r *http.Request) { func ListRouteProvidersHandler(cfgInstance config.ConfigInstance, w http.ResponseWriter, r *http.Request) {
if httpheaders.IsWebsocket(r.Header) { if httpheaders.IsWebsocket(r.Header) {
gpwebsocket.Periodic(w, r, 5*time.Second, func(conn *websocket.Conn) error { gpwebsocket.Periodic(w, r, 5*time.Second, func(conn *websocket.Conn) error {
return wsjson.Write(r.Context(), conn, cfgInstance.RouteProviderList()) return conn.WriteJSON(cfgInstance.RouteProviderList())
}) })
} else { } else {
gphttp.RespondJSON(w, r, cfgInstance.RouteProviderList()) gphttp.RespondJSON(w, r, cfgInstance.RouteProviderList())

View file

@ -4,8 +4,7 @@ import (
"net/http" "net/http"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/coder/websocket/wsjson"
config "github.com/yusing/go-proxy/internal/config/types" config "github.com/yusing/go-proxy/internal/config/types"
"github.com/yusing/go-proxy/internal/net/gphttp" "github.com/yusing/go-proxy/internal/net/gphttp"
"github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket" "github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket"
@ -16,7 +15,7 @@ import (
func Stats(cfg config.ConfigInstance, w http.ResponseWriter, r *http.Request) { func Stats(cfg config.ConfigInstance, w http.ResponseWriter, r *http.Request) {
if httpheaders.IsWebsocket(r.Header) { if httpheaders.IsWebsocket(r.Header) {
gpwebsocket.Periodic(w, r, 1*time.Second, func(conn *websocket.Conn) error { gpwebsocket.Periodic(w, r, 1*time.Second, func(conn *websocket.Conn) error {
return wsjson.Write(r.Context(), conn, getStats(cfg)) return conn.WriteJSON(getStats(cfg))
}) })
} else { } else {
gphttp.RespondJSON(w, r, getStats(cfg)) gphttp.RespondJSON(w, r, getStats(cfg))

View file

@ -8,7 +8,7 @@ import (
"sync" "sync"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/puzpuzpuz/xsync/v4" "github.com/puzpuzpuz/xsync/v4"
"github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket" "github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket"
) )
@ -81,7 +81,7 @@ func (m *memLogger) ServeHTTP(w http.ResponseWriter, r *http.Request) {
m.connChans.Store(logCh, struct{}{}) m.connChans.Store(logCh, struct{}{})
defer func() { defer func() {
_ = conn.CloseNow() _ = conn.Close()
m.notifyLock.Lock() m.notifyLock.Lock()
m.connChans.Delete(logCh) m.connChans.Delete(logCh)
@ -89,7 +89,7 @@ func (m *memLogger) ServeHTTP(w http.ResponseWriter, r *http.Request) {
m.notifyLock.Unlock() m.notifyLock.Unlock()
}() }()
if err := m.wsInitial(r.Context(), conn); err != nil { if err := m.wsInitial(conn); err != nil {
http.Error(w, err.Error(), http.StatusInternalServerError) http.Error(w, err.Error(), http.StatusInternalServerError)
return return
} }
@ -169,15 +169,16 @@ func (m *memLogger) events() (logs <-chan []byte, cancel func()) {
} }
} }
func (m *memLogger) writeBytes(ctx context.Context, conn *websocket.Conn, b []byte) error { func (m *memLogger) writeBytes(conn *websocket.Conn, b []byte) error {
return conn.Write(ctx, websocket.MessageText, b) _ = conn.SetWriteDeadline(time.Now().Add(10 * time.Second))
return conn.WriteMessage(websocket.TextMessage, b)
} }
func (m *memLogger) wsInitial(ctx context.Context, conn *websocket.Conn) error { func (m *memLogger) wsInitial(conn *websocket.Conn) error {
m.Lock() m.Lock()
defer m.Unlock() defer m.Unlock()
return m.writeBytes(ctx, conn, m.Bytes()) return m.writeBytes(conn, m.Bytes())
} }
func (m *memLogger) wsStreamLog(ctx context.Context, conn *websocket.Conn, ch <-chan *logEntryRange) { func (m *memLogger) wsStreamLog(ctx context.Context, conn *websocket.Conn, ch <-chan *logEntryRange) {
@ -188,7 +189,7 @@ func (m *memLogger) wsStreamLog(ctx context.Context, conn *websocket.Conn, ch <-
case logRange := <-ch: case logRange := <-ch:
m.RLock() m.RLock()
msg := m.Bytes()[logRange.Start:logRange.End] msg := m.Bytes()[logRange.Start:logRange.End]
err := m.writeBytes(ctx, conn, msg) err := m.writeBytes(conn, msg)
m.RUnlock() m.RUnlock()
if err != nil { if err != nil {
return return

View file

@ -5,8 +5,7 @@ import (
"net/http" "net/http"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/coder/websocket/wsjson"
metricsutils "github.com/yusing/go-proxy/internal/metrics/utils" metricsutils "github.com/yusing/go-proxy/internal/metrics/utils"
"github.com/yusing/go-proxy/internal/net/gphttp" "github.com/yusing/go-proxy/internal/net/gphttp"
"github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket" "github.com/yusing/go-proxy/internal/net/gphttp/gpwebsocket"
@ -45,7 +44,7 @@ func (p *Poller[T, AggregateT]) ServeHTTP(w http.ResponseWriter, r *http.Request
if data == nil { if data == nil {
return nil return nil
} }
return wsjson.Write(r.Context(), conn, data) return conn.WriteJSON(data)
}) })
} else { } else {
data, err := p.getRespData(r) data, err := p.getRespData(r)

View file

@ -1,11 +1,14 @@
package gpwebsocket package gpwebsocket
import ( import (
"net"
"net/http" "net/http"
"slices"
"strings"
"sync" "sync"
"time" "time"
"github.com/coder/websocket" "github.com/gorilla/websocket"
"github.com/yusing/go-proxy/internal/logging" "github.com/yusing/go-proxy/internal/logging"
) )
@ -27,29 +30,41 @@ func SetWebsocketAllowedDomains(h http.Header, domains []string) {
h[HeaderXGoDoxyWebsocketAllowedDomains] = domains h[HeaderXGoDoxyWebsocketAllowedDomains] = domains
} }
func Initiate(w http.ResponseWriter, r *http.Request) (*websocket.Conn, error) { var localAddresses = []string{"127.0.0.1", "10.0.*.*", "172.16.*.*", "192.168.*.*"}
var originPats []string
localAddresses := []string{"127.0.0.1", "10.0.*.*", "172.16.*.*", "192.168.*.*"} const writeTimeout = time.Second * 10
func Initiate(w http.ResponseWriter, r *http.Request) (*websocket.Conn, error) {
upgrader := websocket.Upgrader{}
allowedDomains := WebsocketAllowedDomains(r.Header) allowedDomains := WebsocketAllowedDomains(r.Header)
if len(allowedDomains) == 0 { if len(allowedDomains) == 0 {
warnNoMatchDomainOnce.Do(warnNoMatchDomains) warnNoMatchDomainOnce.Do(warnNoMatchDomains)
originPats = []string{"*"} upgrader.CheckOrigin = func(r *http.Request) bool {
} else { return true
originPats = make([]string, len(allowedDomains)) }
for i, domain := range allowedDomains { } else {
if domain[0] != '.' { upgrader.CheckOrigin = func(r *http.Request) bool {
originPats[i] = "*." + domain host, _, err := net.SplitHostPort(r.Host)
} else { if err != nil {
originPats[i] = "*" + domain host = r.Host
} }
if slices.Contains(localAddresses, host) {
return true
}
for _, domain := range allowedDomains {
if domain[0] == '.' {
if host == domain[1:] || strings.HasSuffix(host, domain) {
return true
}
} else if host == domain || strings.HasSuffix(host, "."+domain) {
return true
}
}
return false
} }
originPats = append(originPats, localAddresses...)
} }
return websocket.Accept(w, r, &websocket.AcceptOptions{ return upgrader.Upgrade(w, r, nil)
OriginPatterns: originPats,
})
} }
func Periodic(w http.ResponseWriter, r *http.Request, interval time.Duration, do func(conn *websocket.Conn) error) { func Periodic(w http.ResponseWriter, r *http.Request, interval time.Duration, do func(conn *websocket.Conn) error) {
@ -58,8 +73,7 @@ func Periodic(w http.ResponseWriter, r *http.Request, interval time.Duration, do
http.Error(w, err.Error(), http.StatusInternalServerError) http.Error(w, err.Error(), http.StatusInternalServerError)
return return
} }
//nolint:errcheck defer conn.Close()
defer conn.CloseNow()
if err := do(conn); err != nil { if err := do(conn); err != nil {
return return
@ -73,6 +87,7 @@ func Periodic(w http.ResponseWriter, r *http.Request, interval time.Duration, do
case <-r.Context().Done(): case <-r.Context().Done():
return return
case <-ticker.C: case <-ticker.C:
_ = conn.SetWriteDeadline(time.Now().Add(writeTimeout))
if err := do(conn); err != nil { if err := do(conn); err != nil {
return return
} }
@ -83,10 +98,7 @@ func Periodic(w http.ResponseWriter, r *http.Request, interval time.Duration, do
// WriteText writes a text message to the websocket connection. // WriteText writes a text message to the websocket connection.
// It returns true if the message was written successfully, false otherwise. // It returns true if the message was written successfully, false otherwise.
// It logs an error if the message is not written successfully. // It logs an error if the message is not written successfully.
func WriteText(r *http.Request, conn *websocket.Conn, msg string) bool { func WriteText(conn *websocket.Conn, msg string) error {
if err := conn.Write(r.Context(), websocket.MessageText, []byte(msg)); err != nil { _ = conn.SetWriteDeadline(time.Now().Add(writeTimeout))
logging.Err(err).Msg("failed to write text message") return conn.WriteMessage(websocket.TextMessage, []byte(msg))
return false
}
return true
} }

View file

@ -3,16 +3,16 @@ package gpwebsocket
import ( import (
"context" "context"
"github.com/coder/websocket" "github.com/gorilla/websocket"
) )
type Writer struct { type Writer struct {
conn *websocket.Conn conn *websocket.Conn
msgType websocket.MessageType msgType int
ctx context.Context ctx context.Context
} }
func NewWriter(ctx context.Context, conn *websocket.Conn, msgType websocket.MessageType) *Writer { func NewWriter(ctx context.Context, conn *websocket.Conn, msgType int) *Writer {
return &Writer{ return &Writer{
ctx: ctx, ctx: ctx,
conn: conn, conn: conn,
@ -21,9 +21,10 @@ func NewWriter(ctx context.Context, conn *websocket.Conn, msgType websocket.Mess
} }
func (w *Writer) Write(p []byte) (int, error) { func (w *Writer) Write(p []byte) (int, error) {
return len(p), w.conn.Write(w.ctx, w.msgType, p) select {
} case <-w.ctx.Done():
return 0, w.ctx.Err()
func (w *Writer) Close() error { default:
return w.conn.CloseNow() return len(p), w.conn.WriteMessage(w.msgType, p)
}
} }