fix(tests): update health check tests for invalid host and add case for port in host

This commit is contained in:
yusing 2025-05-24 08:42:10 +08:00
parent 6a5cd1266b
commit 22d44a6bb0

View file

@ -172,9 +172,9 @@ func TestCheckHealthTCPUDP(t *testing.T) {
{ {
name: "InvalidHost", name: "InvalidHost",
scheme: "tcp", scheme: "tcp",
host: "invalid", host: "",
port: 8080, port: 8080,
expectedStatus: http.StatusOK, expectedStatus: http.StatusBadRequest,
expectedHealthy: false, expectedHealthy: false,
}, },
{ {
@ -188,9 +188,17 @@ func TestCheckHealthTCPUDP(t *testing.T) {
{ {
name: "InvalidHost", name: "InvalidHost",
scheme: "udp", scheme: "udp",
host: "invalid", host: "",
port: 8080, port: 8080,
expectedStatus: http.StatusOK, expectedStatus: http.StatusBadRequest,
expectedHealthy: false,
},
{
name: "Port in both host and port",
scheme: "tcp",
host: "localhost:1234",
port: 1234,
expectedStatus: http.StatusBadRequest,
expectedHealthy: false, expectedHealthy: false,
}, },
} }
@ -208,9 +216,11 @@ func TestCheckHealthTCPUDP(t *testing.T) {
require.Equal(t, recorder.Code, tt.expectedStatus) require.Equal(t, recorder.Code, tt.expectedStatus)
var result health.HealthCheckResult if tt.expectedStatus == http.StatusOK {
require.NoError(t, json.Unmarshal(recorder.Body.Bytes(), &result)) var result health.HealthCheckResult
require.Equal(t, result.Healthy, tt.expectedHealthy) require.NoError(t, json.Unmarshal(recorder.Body.Bytes(), &result))
require.Equal(t, result.Healthy, tt.expectedHealthy)
}
}) })
} }
} }