From 5769abb62606364da37ad7a56b69c41423ae0015 Mon Sep 17 00:00:00 2001 From: yusing Date: Thu, 9 Jan 2025 18:42:51 +0800 Subject: [PATCH] fix: File.closeOnZero remove unnecessary for loop --- internal/net/http/accesslog/file_logger.go | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/internal/net/http/accesslog/file_logger.go b/internal/net/http/accesslog/file_logger.go index e2dc993..e2ba4bc 100644 --- a/internal/net/http/accesslog/file_logger.go +++ b/internal/net/http/accesslog/file_logger.go @@ -58,14 +58,11 @@ func (f *File) closeOnZero() { defer logger.Debug(). Str("path", f.path). Msg("access log closed") - for { - select { - case <-f.refCount.Zero(): - openedFilesMu.Lock() - delete(openedFiles, f.path) - openedFilesMu.Unlock() - f.File.Close() - return - } - } + + <-f.refCount.Zero() + + openedFilesMu.Lock() + delete(openedFiles, f.path) + openedFilesMu.Unlock() + f.File.Close() }