From 814ff33352cb03f20853a4bf0f7f6501c5ec9427 Mon Sep 17 00:00:00 2001 From: yusing Date: Sun, 13 Jul 2025 13:33:48 +0800 Subject: [PATCH] fix(tests): refactor and fix login in middleware test utils --- internal/net/gphttp/middleware/test_utils.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/internal/net/gphttp/middleware/test_utils.go b/internal/net/gphttp/middleware/test_utils.go index 5b813f3..8e49aae 100644 --- a/internal/net/gphttp/middleware/test_utils.go +++ b/internal/net/gphttp/middleware/test_utils.go @@ -5,6 +5,7 @@ import ( _ "embed" "encoding/json" "io" + "maps" "net/http" "net/http/httptest" @@ -62,11 +63,10 @@ func (rt *requestRecorder) RoundTrip(req *http.Request) (resp *http.Response, er TLS: req.TLS, } } - if err == nil { - for k, v := range rt.args.respHeaders { - resp.Header[k] = v - } + if err != nil { + return nil, err } + maps.Copy(resp.Header, rt.args.respHeaders) return resp, nil } @@ -143,9 +143,7 @@ func newMiddlewaresTest(middlewares []*Middleware, args *testArgs) (*TestResult, args.setDefaults() req := httptest.NewRequest(args.reqMethod, args.reqURL.String(), args.bodyReader()) - for k, v := range args.headers { - req.Header[k] = v - } + maps.Copy(req.Header, args.headers) w := httptest.NewRecorder()