fix extra output of ls-* commands by defer initializaing stuff, speed up start time

cmd/main.go

@@ -35,9 +35,6 @@ func init() {
 	}
 	logging.InitLogger(out)
 	// logging.AddHook(v1.GetMemLogger())
-	internal.InitIconListCache()
-	homepage.InitOverridesConfig()
-	favicon.InitIconCache()
 }
 
 func main() {
@@ -127,6 +124,10 @@ func main() {
 		return
 	}
 
+	go internal.InitIconListCache()
+	go homepage.InitOverridesConfig()
+	go favicon.InitIconCache()
+
 	cfg.Start(&config.StartServersOptions{
 		Proxy: true,
 	})

internal/api/v1/favicon/cache.go

@@ -29,6 +29,9 @@ const (
 )
 
 func InitIconCache() {
+	iconCacheMu.Lock()
+	defer iconCacheMu.Unlock()
+
 	err := utils.LoadJSONIfExist(common.IconCachePath, &iconCache)
 	if err != nil {
 		logging.Error().Err(err).Msg("failed to load icon cache")

internal/homepage/override_config.go

@@ -17,15 +17,17 @@ type OverrideConfig struct {
 	mu             sync.RWMutex
 }
 
-var overrideConfigInstance *OverrideConfig
+var overrideConfigInstance = &OverrideConfig{
+	ItemOverrides:  make(map[string]*ItemConfig),
+	DisplayOrder:   make(map[string]int),
+	CategoryOrder:  make(map[string]int),
+	ItemVisibility: make(map[string]bool),
+}
 
 func InitOverridesConfig() {
-	overrideConfigInstance = &OverrideConfig{
-		ItemOverrides:  make(map[string]*ItemConfig),
-		DisplayOrder:   make(map[string]int),
-		CategoryOrder:  make(map[string]int),
-		ItemVisibility: make(map[string]bool),
-	}
+	overrideConfigInstance.mu.Lock()
+	defer overrideConfigInstance.mu.Unlock()
+
 	err := utils.LoadJSONIfExist(common.HomepageJSONConfigPath, overrideConfigInstance)
 	if err != nil {
 		logging.Error().Err(err).Msg("failed to load homepage overrides config")

internal/list-icons.go

@@ -52,6 +52,9 @@ const (
 )
 
 func InitIconListCache() {
+	iconsCahceMu.Lock()
+	defer iconsCahceMu.Unlock()
+
 	iconsCache = &Cache{
 		WalkxCode:    make(IconsMap),
 		Selfhst:      make(IconsMap),