From d887a37f60adc658523b17c5365118d8d8b46cba Mon Sep 17 00:00:00 2001 From: yusing Date: Mon, 13 Jan 2025 00:52:07 +0800 Subject: [PATCH] fix favicon on non http 200 --- internal/api/v1/favicon/favicon.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/internal/api/v1/favicon/favicon.go b/internal/api/v1/favicon/favicon.go index 508da98..31a37d3 100644 --- a/internal/api/v1/favicon/favicon.go +++ b/internal/api/v1/favicon/favicon.go @@ -131,8 +131,10 @@ func getIconAbsolute(url string) ([]byte, int, string) { } resp, err := U.Get(url) - if err != nil { - storeIconCache(url, nil) + if err != nil || resp.StatusCode != http.StatusOK { + if err == nil { + err = errors.New(resp.Status) + } logging.Error().Err(err). Str("url", url). Msg("failed to get icon") @@ -142,7 +144,6 @@ func getIconAbsolute(url string) ([]byte, int, string) { defer resp.Body.Close() icon, err = io.ReadAll(resp.Body) if err != nil { - // storeIconCache(url, nil) // can retry logging.Error().Err(err). Str("url", url). Msg("failed to read icon")