From f6dc432419d3ae695ebb133c605ec61d231aa82d Mon Sep 17 00:00:00 2001
From: yusing <yusing@6uo.me>
Date: Sat, 1 Mar 2025 15:50:50 +0800
Subject: [PATCH] refactor: fix code formatting and return flow

---
 internal/api/v1/favicon/favicon.go | 3 +--
 internal/api/v1/list.go            | 4 ++--
 internal/route/rules/on_test.go    | 3 ++-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/internal/api/v1/favicon/favicon.go b/internal/api/v1/favicon/favicon.go
index 4c5d8f1..5376644 100644
--- a/internal/api/v1/favicon/favicon.go
+++ b/internal/api/v1/favicon/favicon.go
@@ -36,9 +36,8 @@ func (res *fetchResult) ContentType() string {
 	if res.contentType == "" {
 		if bytes.HasPrefix(res.icon, []byte("<svg")) || bytes.HasPrefix(res.icon, []byte("<?xml")) {
 			return "image/svg+xml"
-		} else {
-			return "image/x-icon"
 		}
+		return "image/x-icon"
 	}
 	return res.contentType
 }
diff --git a/internal/api/v1/list.go b/internal/api/v1/list.go
index 2e861c1..d45ffc4 100644
--- a/internal/api/v1/list.go
+++ b/internal/api/v1/list.go
@@ -39,9 +39,9 @@ func List(cfg config.ConfigInstance, w http.ResponseWriter, r *http.Request) {
 
 	switch what {
 	case ListRoute:
-		if route := listRoute(which); route == nil {
+		route := listRoute(which)
+		if route == nil {
 			http.NotFound(w, r)
-			return
 		} else {
 			U.RespondJSON(w, r, route)
 		}
diff --git a/internal/route/rules/on_test.go b/internal/route/rules/on_test.go
index a27fa1a..7c671ce 100644
--- a/internal/route/rules/on_test.go
+++ b/internal/route/rules/on_test.go
@@ -234,7 +234,8 @@ func TestOnCorrectness(t *testing.T) {
 
 	tests = append(tests, genCorrectnessTestCases("header", func(k, v string) *http.Request {
 		return &http.Request{
-			Header: http.Header{k: []string{v}}}
+			Header: http.Header{k: []string{v}},
+		}
 	})...)
 	tests = append(tests, genCorrectnessTestCases("query", func(k, v string) *http.Request {
 		return &http.Request{