Merge 4082895714 into 443d5cf554

db/knex_migrations/2025-06-13-0000-maintenance-add-last-start.js

@@ -0,0 +1,34 @@
+// Add column last_start_date to maintenance table
+exports.up = async function (knex) {
+    await knex.schema
+        .alterTable("maintenance", function (table) {
+            table.datetime("last_start_date");
+        });
+
+    // Perform migration for recurring-interval strategy
+    const recurringMaintenances = await knex("maintenance").where({
+        strategy: "recurring-interval",
+        cron: "* * * * *"
+    }).select("id", "start_time");
+
+    // eslint-disable-next-line camelcase
+    const maintenanceUpdates = recurringMaintenances.map(async ({ start_time, id }) => {
+        // eslint-disable-next-line camelcase
+        const [ hourStr, minuteStr ] = start_time.split(":");
+        const hour = parseInt(hourStr, 10);
+        const minute = parseInt(minuteStr, 10);
+
+        const cron = `${minute} ${hour} * * *`;
+
+        await knex("maintenance")
+            .where({ id })
+            .update({ cron });
+    });
+    await Promise.all(maintenanceUpdates);
+};
+
+exports.down = function (knex) {
+    return knex.schema.alterTable("maintenance", function (table) {
+        table.dropColumn("last_start_date");
+    });
+};

server/model/maintenance.js

@@ -202,7 +202,7 @@ class Maintenance extends BeanModel {
      * @returns {void}
      */
     static validateCron(cron) {
-        let job = new Cron(cron, () => {});
+        let job = new Cron(cron, () => { });
         job.stop();
     }
 
@@ -239,6 +239,8 @@ class Maintenance extends BeanModel {
                 apicache.clear();
             });
         } else if (this.cron != null) {
+            let current = dayjs();
+
             // Here should be cron or recurring
             try {
                 this.beanMeta.status = "scheduled";
@@ -258,6 +260,10 @@ class Maintenance extends BeanModel {
                         this.beanMeta.status = "scheduled";
                         UptimeKumaServer.getInstance().sendMaintenanceListByUserID(this.user_id);
                     }, duration);
+
+                    // Set last start date to current time
+                    this.last_start_date = current.toISOString();
+                    R.store(this);
                 };
 
                 // Create Cron
@@ -268,9 +274,25 @@ class Maintenance extends BeanModel {
                     const startDateTime = startDate.hour(hour).minute(minute);
                     this.beanMeta.job = new Cron(this.cron, {
                         timezone: await this.getTimezone(),
-                        interval: this.interval_day * 24 * 60 * 60,
                         startAt: startDateTime.toISOString(),
-                    }, startEvent);
+                    }, () => {
+                        if (!this.lastStartDate || this.interval_day === 1) {
+                            return startEvent();
+                        }
+
+                        // If last start date is set, it means the maintenance has been started before
+                        let lastStartDate = dayjs(this.lastStartDate)
+                            .subtract(1.1, "hour"); // Subtract 1.1 hour to avoid issues with timezone differences
+
+                        // Check if the interval is enough
+                        if (current.diff(lastStartDate, "day") < this.interval_day) {
+                            log.debug("maintenance", "Maintenance id: " + this.id + " is still in the window, skipping start event");
+                            return;
+                        }
+
+                        log.debug("maintenance", "Maintenance id: " + this.id + " is not in the window, starting event");
+                        return startEvent();
+                    });
                 } else {
                     this.beanMeta.job = new Cron(this.cron, {
                         timezone: await this.getTimezone(),
@@ -279,7 +301,6 @@ class Maintenance extends BeanModel {
 
                 // Continue if the maintenance is still in the window
                 let runningTimeslot = this.getRunningTimeslot();
-                let current = dayjs();
 
                 if (runningTimeslot) {
                     let duration = dayjs(runningTimeslot.endDate).diff(current, "second") * 1000;
@@ -423,8 +444,11 @@ class Maintenance extends BeanModel {
         } else if (!this.strategy.startsWith("recurring-")) {
             this.cron = "";
         } else if (this.strategy === "recurring-interval") {
-            // For intervals, the pattern is calculated in the run function as the interval-option is set
+            // For intervals, the pattern is used to check if the execution should be started
-            this.cron = "* * * * *";
+            let array = this.start_time.split(":");
+            let hour = parseInt(array[0]);
+            let minute = parseInt(array[1]);
+            this.cron = `${minute} ${hour}  * * *`;
             this.duration = this.calcDuration();
             log.debug("maintenance", "Cron: " + this.cron);
             log.debug("maintenance", "Duration: " + this.duration);