From 1e4bc5ddb5708a4ce0b6a57dc300351033347252 Mon Sep 17 00:00:00 2001 From: Ionys <9364594+Ionys320@users.noreply.github.com> Date: Thu, 26 Jun 2025 16:14:49 +0200 Subject: [PATCH] fix(lint): Correct the issues Sorry, my ESLint extension was disabled --- src/components/settings/Users/EditUser.vue | 6 +++--- src/components/settings/Users/Users.vue | 2 +- test/e2e/specs/multiple-users.spec.js | 9 ++++++--- test/e2e/util-test.js | 2 +- 4 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/components/settings/Users/EditUser.vue b/src/components/settings/Users/EditUser.vue index 64cb8727f..4e36f045b 100644 --- a/src/components/settings/Users/EditUser.vue +++ b/src/components/settings/Users/EditUser.vue @@ -82,8 +82,8 @@ style="scale: 1.4; cursor: pointer;" type="checkbox" :disabled="saving" - @click="debounceCheckboxClick(() => { active = !active; save({ active }); })" data-testid="active-checkbox" + @click="debounceCheckboxClick(() => { active = !active; save({ active }); })" >
{{ $t("Active") }}
@@ -181,8 +181,8 @@ export default { /** * Save user changes * @param {object} user user to save - * @param {string} [user.username] username used as login identifier. - * @param {boolean} [user.active] is the user authorized to login? + * @param {string} user.username username used as login identifier. + * @param {boolean} user.active is the user authorized to login? * @returns {void} */ save(user) { diff --git a/src/components/settings/Users/Users.vue b/src/components/settings/Users/Users.vue index 4f58c2035..02d7e5e9c 100644 --- a/src/components/settings/Users/Users.vue +++ b/src/components/settings/Users/Users.vue @@ -31,8 +31,8 @@ class="btn-ban-user btn ms-2 py-1" :class="active ? 'btn-outline-danger' : 'btn-outline-success'" :disabled="processing" - @click.prevent="active ? disableConfirm(usersList[index]) : toggleActiveUser(usersList[index])" :data-testid="`toggle-active-user-${username}`" + @click.prevent="active ? disableConfirm(usersList[index]) : toggleActiveUser(usersList[index])" > diff --git a/test/e2e/specs/multiple-users.spec.js b/test/e2e/specs/multiple-users.spec.js index 63ff6545e..058de2187 100644 --- a/test/e2e/specs/multiple-users.spec.js +++ b/test/e2e/specs/multiple-users.spec.js @@ -24,7 +24,7 @@ test.describe("Multiple Users", () => { await page.getByTestId("password-input").fill("newuser123"); await page.getByTestId("password-repeat-input").fill("newuser123"); await page.getByTestId("submit-create-admin-form").click(); - + // Ensure the new user is created and visible in the user list await page.waitForURL("./settings/users"); await expect(page.getByTestId("users-list")).toContainText("newuser"); @@ -35,9 +35,12 @@ test.describe("Multiple Users", () => { // Disable the admin user await page.getByTestId("toggle-active-user-admin").click(); // Click on the button containing Yes and having btn-danger class - await page.getByRole("button", { name: "Yes", exact: true}).click(); + await page.getByRole("button", { + name: "Yes", + exact: true + }).click(); await expect(page.getByText("You are not logged in.")).toBeVisible(); - + // Make sure we're back on the login page after refresh await page.reload(); await expect(page.getByText("Log in")).toBeVisible(); diff --git a/test/e2e/util-test.js b/test/e2e/util-test.js index e22c909de..5e85f4ef8 100644 --- a/test/e2e/util-test.js +++ b/test/e2e/util-test.js @@ -19,7 +19,7 @@ export async function screenshot(testInfo, page) { /** * @param {Page} page Page - * @param {string} [user="admin"] Username to log in with + * @param {string} user Username to log in with * @returns {Promise} */ export async function login(page, user = "admin") {