From 2d67631cb2c1abf5342f745185373384c9bad87f Mon Sep 17 00:00:00 2001 From: Marshu Date: Sat, 19 Apr 2025 14:33:21 +0800 Subject: [PATCH] Remove redundant code --- src/components/MonitorSettingDialog.vue | 24 +- src/components/PublicGroupList.vue | 1313 ++--------------------- src/icon.js | 8 +- src/lang/en.json | 1 - src/lang/zh-CN.json | 5 +- src/pages/StatusPage.vue | 8 +- 6 files changed, 86 insertions(+), 1273 deletions(-) diff --git a/src/components/MonitorSettingDialog.vue b/src/components/MonitorSettingDialog.vue index 1d3cf4a3f..e6b2cd1ef 100644 --- a/src/components/MonitorSettingDialog.vue +++ b/src/components/MonitorSettingDialog.vue @@ -72,17 +72,11 @@ export default { * @returns {void} */ show(group, monitor) { - // Check if monitor exists and has required properties - if (!monitor || !monitor.id) { - console.error("Invalid monitor object", monitor); - return; - } - this.monitor = { - id: monitor.id, - name: monitor.name, - monitor_index: monitor.index || 0, - group_index: group.index || 0, + id: monitor.element.id, + name: monitor.element.name, + monitor_index: monitor.index, + group_index: group.index, isClickAble: this.showLink(monitor), }; @@ -109,18 +103,12 @@ export default { * @returns {boolean} Should the link be shown? */ showLink(monitor, ignoreSendUrl = false) { - if (!monitor || !monitor.id) { - return false; - } - // We must check if there are any elements in monitorList to // prevent undefined errors if it hasn't been loaded yet if (this.$parent.editMode && ignoreSendUrl && Object.keys(this.$root.monitorList).length) { - return this.$root.monitorList[monitor.id].type === "http" || - this.$root.monitorList[monitor.id].type === "keyword" || - this.$root.monitorList[monitor.id].type === "json-query"; + return this.$root.monitorList[monitor.element.id].type === "http" || this.$root.monitorList[monitor.element.id].type === "keyword" || this.$root.monitorList[monitor.element.id].type === "json-query"; } - return monitor.sendUrl && monitor.url && monitor.url !== "https://" && !this.editMode; + return monitor.element.sendUrl && monitor.element.url && monitor.element.url !== "https://" && !this.editMode; }, }, }; diff --git a/src/components/PublicGroupList.vue b/src/components/PublicGroupList.vue index 252f8df9c..bacddbf13 100644 --- a/src/components/PublicGroupList.vue +++ b/src/components/PublicGroupList.vue @@ -1,236 +1,59 @@