From 783655b0d8e1901c0db06576724c79da1504b803 Mon Sep 17 00:00:00 2001
From: Fabian Triebsch <online-github@email.abcde.biz>
Date: Wed, 11 Jun 2025 15:14:55 +0200
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Frank Elsinga <frank@elsinga.de>
---
 src/lang/en.json          |  2 +-
 src/pages/EditMonitor.vue | 22 ++++++++--------------
 2 files changed, 9 insertions(+), 15 deletions(-)

diff --git a/src/lang/en.json b/src/lang/en.json
index 98b18bee3..538309dba 100644
--- a/src/lang/en.json
+++ b/src/lang/en.json
@@ -1113,5 +1113,5 @@
     "smsplanetNeedToApproveName": "Needs to be approved in the client panel",
     "Disable URL in Notification": "Disable URL in Notification",
     "Ip Family": "IP Family",
-    "ipFamilyDescription": "Choose the IP version to use (IPv4 or IPv6). If \"auto-select\" is chosen, it will use \"Happy Eyeballs\" for determining the IP version."
+    "ipFamilyDescriptionAutoSelect": "Use {happyEyeballs} for determining the IP family."
 }
diff --git a/src/pages/EditMonitor.vue b/src/pages/EditMonitor.vue
index 9dda18566..5d3609c86 100644
--- a/src/pages/EditMonitor.vue
+++ b/src/pages/EditMonitor.vue
@@ -748,22 +748,16 @@
 
                                 <div class="my-3">
                                     <label for="ipFamily" class="form-label">{{ $t("Ip Family") }}</label>
-
                                     <select id="ipFamily" v-model="monitor.ipFamily" class="form-select">
-                                        <option :value="null">
-                                            {{ $t("auto-select") }}
-                                        </option>
-                                        <option value="ipv4">
-                                            IPv4
-                                        </option>
-                                        <option value="ipv6">
-                                            IPv6
-                                        </option>
+                                        <option :value="null">{{ $t("auto-select") }}</option>
+                                        <option value="ipv4">IPv4</option>
+                                        <option value="ipv6">IPv6</option>
                                     </select>
-
-                                    <div class="form-text">
-                                        {{ $t("ipFamilyDescription") }} (<a href="https://en.wikipedia.org/wiki/Happy_Eyeballs" target="_blank">{{ $t('Learn More') }}</a>)
-                                    </div>
+                                    <i18n-t tag="div" class="form-text" key="ipFamilyDescriptionAutoSelect" v-if="monitor.ipFamily === 'null'">
+                                        <template #happyEyeballs>
+                                            <a href="https://en.wikipedia.org/wiki/Happy_Eyeballs" target="_blank">"Happy Eyeballs"</a>
+                                        </template
+                                    </i18n-t>
                                 </div>
                             </template>