TyleoDvDelaware3217/Kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2025-06-06 21:12:34 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Apply suggestions from code review

Browse source 
Co-authored-by: Frank Elsinga <frank@elsinga.de>
This commit is contained in:
Aleksander 2025-04-24 09:38:33 +02:00 • committed by GitHub
parent 213c4c0342
commit cd22baab1d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 10 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
server/notification-providers/smseagle.js
View file

@ -33,11 +33,7 @@ class SMSEagle extends NotificationProvider {
recipientType = "to"; recipientType = "to";
sendMethod = "/send_sms"; sendMethod = "/send_sms";
if (notification.smseagleMsgType !== "smseagle-sms") { if (notification.smseagleMsgType !== "smseagle-sms") {
if (notification.smseagleDuration) { duration = notification.smseagleDuration ?? 10;
duration = notification.smseagleDuration;
} else {
duration = 10;
}
if (notification.smseagleMsgType === "smseagle-ring") { if (notification.smseagleMsgType === "smseagle-ring") {
sendMethod = "/ring_call"; sendMethod = "/ring_call";
@ -54,7 +50,7 @@ class SMSEagle extends NotificationProvider {
url.searchParams.append("access_token", notification.smseagleToken); url.searchParams.append("access_token", notification.smseagleToken);
url.searchParams.append(recipientType, notification.smseagleRecipient); url.searchParams.append(recipientType, notification.smseagleRecipient);
if (![ "smseagle-ring", "smseagle-tts", "smseagle-tts-advanced" ].includes(notification.smseagleRecipientType)) { if ("smseagle-sms" === notification.smseagleRecipientType) {
url.searchParams.append("unicode", (notification.smseagleEncoding) ? "1" : "0"); url.searchParams.append("unicode", (notification.smseagleEncoding) ? "1" : "0");
url.searchParams.append("highpriority", (notification.smseaglePriority) ? notification.smseaglePriority : "0"); url.searchParams.append("highpriority", (notification.smseaglePriority) ? notification.smseaglePriority : "0");
} else { } else {
@ -142,22 +138,18 @@ class SMSEagle extends NotificationProvider {
let resp = await axios.post(notification.smseagleUrl + "/api/v2" + endpoint, postData, config); let resp = await axios.post(notification.smseagleUrl + "/api/v2" + endpoint, postData, config);
let countAll = resp.data.length; const queuedCount = resp.data.filter(x => x.status === "queued").length;
let countQueued = resp.data.filter(x => x.status === "queued").length; const unqueuedCount = resp.data.length - queuedCount;
if (resp.status !== 200 || countQueued === 0) { if (resp.status !== 200 || queuedCount === 0) {
let error = ""; if (!resp.data.length) {
if (resp.data.length > 0) { throw new Error("SMSEagle API returned an empty response");
error = `SMSEagle API returned error: ${JSON.stringify(resp.data)}`;
} else {
error = "SMSEagle API returned an unexpected response";
} }
throw new Error(error); throw new Error(`SMSEagle API returned error: ${JSON.stringify(resp.data)}`);
} }
if (countAll !== countQueued) { if (unqueuedCount) {
let okWithErrorsMsg = "Sent " + countQueued + "/" + countAll + " Messages Successfully."; return `Sent ${countQueued}/${resp.data.length} Messages Successfully.`;
return okWithErrorsMsg;
} }
return okMsg; return okMsg;