TyleoDvDelaware3217/Kuma
1
0
Fork 0
mirror of https://github.com/louislam/uptime-kuma.git synced 2025-07-18 23:34:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Apply suggestions from code review

Browse source
This commit is contained in:
Frank Elsinga 2025-06-24 17:11:50 +02:00 • committed by GitHub
parent cfde1a7ed2
commit fc734e7af4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
server/prometheus.js
View file

@ -41,20 +41,17 @@ class Prometheus {
* @param {Array<{name:string,value:?string}>} tags Tags to add to the monitor * @param {Array<{name:string,value:?string}>} tags Tags to add to the monitor
*/ */
constructor(monitor, tags) { constructor(monitor, tags) {
let sanitizedTags = this.sanitizeTags(tags);
if (sanitizedTags.length <= 0) {
sanitizedTags = "null";
}
this.monitorLabelValues = { this.monitorLabelValues = {
monitor_name: monitor.name, monitor_name: monitor.name,
monitor_type: monitor.type, monitor_type: monitor.type,
monitor_url: monitor.url, monitor_url: monitor.url,
monitor_hostname: monitor.hostname, monitor_hostname: monitor.hostname,
monitor_port: monitor.port, monitor_port: monitor.port,
monitor_tags: sanitizedTags
}; };
let sanitizedTags = this.sanitizeTags(tags);
if (sanitizedTags.length) {
this.monitorLabelValues.monitor_tags = sanitizedTags
}
} }
/** /**
@ -65,7 +62,7 @@ class Prometheus {
*/ */
sanitizeTags(tags) { sanitizeTags(tags) {
return tags.reduce((sanitizedTags, tag) => { return tags.reduce((sanitizedTags, tag) => {
let tagText = tag.name; let tagText = tag.value ? `${tag.name}_${tag.value}` : tag.name;
tagText = tagText.replace(/[^a-zA-Z0-9_]/g, ""); tagText = tagText.replace(/[^a-zA-Z0-9_]/g, "");
tagText = tagText.replace(/^[^a-zA-Z_]+/, ""); tagText = tagText.replace(/^[^a-zA-Z_]+/, "");