Toby Liddicoat
9081025c4a
Refactor modules for improved readability and consistency
...
Reformatted code across multiple modules, standardizing string quotes, indentation, and spacing. Improved readability by restructuring blocks and aligning object properties consistently. These changes ensure better code maintainability and follow standard conventions.
Signed-off-by: Toby Liddicoat <toby@codesure.co.uk>
2025-02-27 19:58:07 +00:00
Louis Lam
4d16575599
Merge branch 'master' into 1.23.X-to-2
...
# Conflicts:
# package-lock.json
# package.json
2024-12-20 15:38:45 +08:00
Louis Lam
6cfae01a0d
Merge commit from fork
...
* [V1 Only] Change dev server's data path to ./data/v1
* Fix GHSA-2qgm-m29m-cj2h
2024-12-20 15:02:22 +08:00
Suven-p
c01494ec33
feat: add RabbitMQ
monitor ( #5199 )
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-10-20 15:57:03 +02:00
Louis Lam
eca90a2b00
Revert "feat: structured logging (JSON)" ( #5175 )
2024-10-09 07:43:44 +08:00
Cassandra
b287a25de7
feat: structured logging (JSON) ( #5118 )
2024-09-24 17:51:21 +08:00
Shaun
36f8be040d
Monitor Conditions ( #5048 )
2024-08-30 21:48:13 +02:00
Matt Visnovsky
a0374487ce
C&P typo from review
2024-06-14 16:44:36 -06:00
Matt Visnovsky
092688a5c8
ES Lint
2024-06-13 12:15:13 -06:00
Matt Visnovsky
6fc0cbf415
ES Lint
2024-06-13 12:12:17 -06:00
Frank Elsinga
c124f3a43e
Formtting fix
2024-06-12 23:24:10 +02:00
Matt Visnovsky
b5a73e5ad7
Apply suggestions from code review
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-06-12 14:25:25 -06:00
Frank Elsinga
5dc4bb64d5
Merge branch 'master' into snmp-monitor
2024-06-12 19:55:31 +02:00
Frank Elsinga
b6cd21c71a
Removed where I was wrong about imports
2024-06-07 15:54:28 +02:00
Matt Visnovsky
fdc145bffd
Added Robustness
...
There are a lot of changes here:
-Fixed a lot of issues encountered during my testing
-JSON path is evaluated BEFORE making comparisons (this was the true intended behavior by @chakflying)
-Variable name changes (cosmetic)
-Added != operator
-Changed jsonQueryDescription (again)
2024-06-06 18:52:33 -06:00
Matt Visnovsky
eaa935cba0
Also return result of the evaluation
...
-Maximum compatibility with @chakflying's existing json-query monitor code.
2024-06-06 10:09:35 -06:00
Matt Visnovsky
efb1642e3c
Blend json-query and snmp monitors
...
Utilizes the JSON Query library to handle comparison logic.
2024-06-05 16:09:53 -06:00
Matt Visnovsky
2d2c1866df
Fix: a typo
2024-06-05 15:40:07 -06:00
Matt Visnovsky
b2d76bc60a
Refactor line for conciseness
2024-06-05 15:39:55 -06:00
Matt Visnovsky
7eee5db4d2
Variable changes
...
-Reuse expected_value for snmpControlValue
-Create jsonPathOperator for snmpCondition
2024-06-05 15:37:47 -06:00
Frank Elsinga
d74facded6
removed some monitor drift in terms of imports and documentation
2024-06-04 05:01:53 +02:00
Sebastian Lang
a3ac954140
Add support for custom mongodb commands ( #4445 )
...
Co-authored-by: Sebastian Lang <sebastian.lang@damovo.com>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-05-19 21:59:57 +02:00
Matt Visnovsky
d25ee8f128
Using JSON Query Expressions
...
Equivalent functionality as before, but we're now building json-query expressions for the user.
2024-05-10 10:56:38 -06:00
Matt Visnovsky
1c4740748c
Re-use monitor.radiusPassword for community string
2024-05-08 11:00:10 -06:00
Matt Visnovsky
da8f0d1c31
Apply suggestions from code review
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-05-08 10:06:20 -06:00
Matt Visnovsky
2b5d100cd3
Ensure SNMP session is closed properly
...
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589858252
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 15:56:41 -06:00
Matt Visnovsky
e9b52eb0e7
Separate error cases for SNMP varbind returns
2024-05-06 14:06:40 -06:00
Matt Visnovsky
c68b1c6274
Remove unnecessary func getKey
2024-05-06 12:05:12 -06:00
Matt Visnovsky
433e317eee
Simplify error catch
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 09:57:13 -06:00
Matt Visnovsky
1fe1bb5864
Given that above throws, the else case is not nessesary
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 09:53:14 -06:00
Matt Visnovsky
997791bc78
Default: invalid condition error
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-05-06 09:51:37 -06:00
Matt Visnovsky
0384b34007
Remove unnecessary func getKey
...
Addresses:
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589856311
- https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589862733
2024-05-06 09:49:36 -06:00
Matt Visnovsky
0280b2ad3f
A comment about varbinds[0] for clarification
...
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589855126
2024-05-06 09:21:49 -06:00
Matt Visnovsky
4386d0afad
Apply suggestions from code review
...
Addresses:
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589805237
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589806199
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589853470
-https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1589854032
2024-05-05 15:47:43 -06:00
Matt Visnovsky
09fd816aae
Updated code comments
2024-05-03 11:52:02 -06:00
Matt Visnovsky
c87ac2f043
Move getKey() to util.ts
2024-05-03 11:39:14 -06:00
Matt Visnovsky
8e56a81ef1
Refactor how strings/numerics are parsed
...
Fixes issue `toString() radix argument must be between 2 and 36` due to `.toString("ascii")` conversion. This issue was introduced in 704ffd3f4b
.
2024-05-02 15:11:03 -06:00
Matt Visnovsky
f059d54349
Use frontend timeout
...
Addresses https://github.com/louislam/uptime-kuma/pull/4717#discussion_r1585616669
2024-05-02 15:07:22 -06:00
Matt Visnovsky
9ba0f68a86
Remove supurfluous log.debug
...
Co-Authored-By: Frank Elsinga <frank.elsinga@tum.de>
2024-04-30 18:19:18 -06:00
Matt Visnovsky
7459654e11
ES Lint Compliant
2024-04-30 18:04:59 -06:00
Matt Visnovsky
ba47aca51f
Apply suggestions from code review
...
Co-authored-by: Frank Elsinga <frank@elsinga.de>
2024-04-30 17:54:29 -06:00
Frank Elsinga
b4bd003626
Merge branch 'master' into snmp-monitor
2024-05-01 00:01:03 +02:00
Matt Visnovsky
704ffd3f4b
Finalized SNMP monitor
2024-04-30 15:18:25 -06:00
Matt Visnovsky
99dc4cfb46
Wrong variable used
...
Thanks for pointing it out @CommanderStorm!
2024-04-29 22:24:51 -06:00
Matt Visnovsky
4a882be6ba
Further SNMP monitor development
...
Further testing of SNMP feat, however I'm running into the issue `Error in SNMP check: RequestTimedOutError: Request timed out` when the check function is called. I am unsure as to why since my local SNMP script works great with very similar code.
2024-04-29 15:59:59 -06:00
Matt Visnovsky
a3cdd69995
Use net-snmp instead of snmp-native
...
net-snmp over snmp-native is:
-more robust
-more popular
-better documented
-supports v3
2024-04-29 13:58:43 -06:00
Matt Visnovsky
d92003e172
SNMP Initial Commits
...
This commit introduces a new SNMP monitor feature to the application, allowing users to monitor devices using SNMP (Simple Network Management Protocol).
2024-04-26 19:05:56 -06:00
Louis Lam
63a380326d
Merge branch '1.23.X' into 1.23.13-to-2.0.0
...
# Conflicts:
# .github/workflows/auto-test.yml
# package-lock.json
# package.json
# server/database.js
# server/model/monitor.js
# server/monitor-types/real-browser-monitor-type.js
# server/util-server.js
# test/cypress/unit/i18n.spec.js
2024-04-25 15:42:53 +08:00
Frank Elsinga
0e3b3a9ab8
Made sure that more of the async usages are awaited ( #4574 )
2024-03-15 15:02:55 +01:00
Frank Elsinga
a9a1cf1353
Chore: General notification reformatting ( #3182 )
...
- I unified where in file the name of `NotificationProvider.name` is placed
- I made sure that all the providers adhere to the signature of `NotificationProvider.send()`
- I made sure that all the providers use `okMsg` if returning success messages directly from the function.
Here a discussion should be had:
Should this be refactored into a constant of `NotificationProvider`? I could imagine that `NotificationProvider.SENDING_SUCCESSFULL` could be a suitable alternative.
- I made sure all providers have the URL they `POST`/`GET` to be extraced into a variable.
=> refactored this way due to Nelsons suggestion
2024-03-14 14:21:15 +01:00